Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #80 - nav links not working #93

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

Dhruv-pahuja
Copy link
Contributor

Overview

This PR fixes issue #80 where the Nav links were not working in Navbar

Changes

  • I Modified the App.tsx by moving the Navbar out of the Route , so that i can appear over all pages
  • add the routes for clubs and events
  • removed the extra navigation that was overlapping in About page

Issue Reference

Fixes #80

Screenshots

  • Before:
    image

  • After:
    image

Additional Notes

  • I have contributed to this project as part of Hacktoberfest 2024 and GirlScript Summer of Code 2024 - Extended Edition (GSSoC-Ext).

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dypcetclubs-live ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:48am

@Dhruv-pahuja
Copy link
Contributor Author

please Add gsocc-ext ,level1, hacktoberfest and hacktoberfest-accepted labels to this PR too as of latest guideliness by GSSoc-ext and hacktoberfest @Yash-Ainapure

@Yash-Ainapure Yash-Ainapure merged commit b82b9e7 into Yash-Ainapure:main Oct 18, 2024
3 checks passed
@Dhruv-pahuja
Copy link
Contributor Author

@Yash-Ainapure @sanjay-kv can anyone please add labels to this pr also to make it consider in gssoc-ext

Dhruv-pahuja added a commit to Dhruv-pahuja/Open-source-Practice that referenced this pull request Nov 9, 2024
Hey Gssoc Team,

this is my second PR that has been merged  but no labels were provided to it   
Yash-Ainapure/dypcetclubs.live#93

It belongs to **level1**

Can you please review it and merge it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav link not woking
2 participants